apt: improve doc+test for get_remote_versions_for_package

Those concern the case where we find origins in the local dpkg cache (installed versions), and ignore them. Signed-off-by: Renan Rodrigo <[email protected]>
canonical · Oct 26, 2023 · 3ffb7f6 · 3ffb7f6
1 parent 00bf3dc
commit 3ffb7f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/uaclient/apt.py b/uaclient/apt.py
@@ -462,6 +462,9 @@ def get_remote_versions_for_package(
         valid_origins = [
             file
             for file, _ in version.file_list
+            # component == now means we are getting it from the local dpkg
+            # cache, and we don't really care about those entries because
+            # they are the currently installed version of the package.
             if file.component != "now" and file.origin != exclude_origin
         ]
         if valid_origins:

diff --git a/uaclient/tests/test_apt.py b/uaclient/tests/test_apt.py
@@ -1441,7 +1441,9 @@ def test_get_remote_versions_excluding_origin(self):
                 get_remote_versions_for_package(
                     mock_package(
                         "name",
-                        installed_version=mock_version("1.0"),
+                        installed_version=mock_version(
+                            "1.0", [mock_origin("now", "", "Origin1", "")]
+                        ),
                         other_versions=[
                             mock_version(
                                 "0.9", [mock_origin("", "", "Origin1", "")]