ci: fix null exception in checklist actions

canonical · Jun 17, 2024 · 7b7055a · 7b7055a
1 parent e3d31f3
commit 7b7055a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/.github/actions/pr-checklist/index.js b/.github/actions/pr-checklist/index.js
@@ -104,7 +104,7 @@ function createTestUpdatesSection({
 }) {
     const header = commentSectionHeader(TEST_UPDATES);
     const footer = commentSectionFooter(TEST_UPDATES);
-    const existingSection = existingBody ? getCommentSection(TEST_UPDATES, existingBody) : null;
+    const existingSection = existingBody ? getCommentSection(TEST_UPDATES, existingBody) : "";
     const unitTestCheck = existingSection.includes(`- [x] ${unitTestsUpdated}`) ? "x" : " "
     const unitTestNotCheck = existingSection.includes(`- [x] ${unitTestsNotUpdated}`) ? "x" : " "
     const integrationTestCheck = existingSection.includes(`- [x] ${integrationTestsUpdated}`) ? "x" : " "
@@ -141,7 +141,7 @@ function createDocsSection({
 }) {
     const header = commentSectionHeader(DOCS);
     const footer = commentSectionFooter(DOCS);
-    const existingSection = existingBody ? getCommentSection(DOCS, existingBody) : null;
+    const existingSection = existingBody ? getCommentSection(DOCS, existingBody) : "";
     const docsCheck = existingSection.includes(`- [x] ${docsUpdated}`) ? "x" : " "
     const docsNotCheck = existingSection.includes(`- [x] ${docsNotUpdated}`) ? "x" : " "
 
@@ -171,7 +171,7 @@ function createExtraReviewsSection({
 }) {
     const header = commentSectionHeader(EXTRA_REVIEWS);
     const footer = commentSectionFooter(EXTRA_REVIEWS);
-    const existingSection = existingBody ? getCommentSection(EXTRA_REVIEWS, existingBody) : null;
+    const existingSection = existingBody ? getCommentSection(EXTRA_REVIEWS, existingBody) : "";
     const extraReviewsCheck = existingSection.includes(`- [x] ${extraReviewsNeeded}`) ? "x" : " "
     const extraReviewsNotCheck = existingSection.includes(`- [x] ${extraReviewsNotNeeded}`) ? "x" : " "
 

diff --git a/.github/actions/release-checklist/index.js b/.github/actions/release-checklist/index.js
@@ -29,7 +29,7 @@ function createBugRefsSection({
 }) {
     const header = commentSectionHeader(BUG_REFS);
     const footer = commentSectionFooter(BUG_REFS);
-    const existingSection = existingBody ? getCommentSection(BUG_REFS, existingBody) : null;
+    const existingSection = existingBody ? getCommentSection(BUG_REFS, existingBody) : "";
     const verified = existingSection ? bugRefsVerified(existingSection) : false;