Skip to content

Commit

Permalink
lintian: fix or override errors and warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
orndorffgrant committed Jan 19, 2024
1 parent 3162733 commit cc85f61
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 14 deletions.
12 changes: 7 additions & 5 deletions debian/control
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,13 @@ Vcs-Browser: https://github.com/canonical/ubuntu-pro-client
Rules-Requires-Root: no

Package: ubuntu-advantage-tools
Depends: ubuntu-pro-client (= ${binary:Version}), ${misc:Depends}
Depends: ubuntu-pro-client (>= ${binary:Version}), ${misc:Depends}
Architecture: all
Priority: optional
Section: oldlibs
Description: transitional package
This is a transitional package. It can safely be removed.
Description: transitional dummy package for ubuntu-pro-client
This is a transitional dummy package for ubuntu-pro-client. It can safely be
removed.

Package: ubuntu-pro-client
Homepage: https://canonical-ubuntu-pro-client.readthedocs-hosted.com/
Expand Down Expand Up @@ -75,8 +76,9 @@ Depends: ubuntu-pro-image-auto-attach, ${misc:Depends}
Architecture: all
Priority: optional
Section: oldlibs
Description: transitional package
This is a transitional package. It can safely be removed.
Description: transitional dummy package for ubuntu-pro-image-auto-attach
This is a transitional dummy package for ubuntu-pro-image-auto-attach. It can
safely be removed.

Package: ubuntu-pro-image-auto-attach
Homepage: https://canonical-ubuntu-pro-client.readthedocs-hosted.com/en/latest/explanations/what_are_ubuntu_pro_cloud_instances/
Expand Down
14 changes: 9 additions & 5 deletions debian/ubuntu-advantage-tools.lintian-overrides
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# We are silencing this issue because of this LP: #1930121
ubuntu-advantage-tools: command-with-path-in-maintainer-script

# Ubuntu doesn't support sysv init.d
ubuntu-advantage-tools: package-supports-alternative-init-but-no-init.d-script
ubuntu-advantage-tools: possible-bashism-in-maintainer-script

# We have made the decision of delivering those files
ubuntu-advantage-tools: package-installs-apt-preferences
# python3 is a transitive dependency via ubuntu-pro-client
ubuntu-advantage-tools: python3-script-but-no-python3-dep

ubuntu-advantage-tools: possible-bashism-in-maintainer-script
# This is only to cleanup an old tmp file
ubuntu-advantage-tools: possibly-insecure-handling-of-tmp-files-in-maintainer-script /tmp [postinst:61]

# systemctl is the only way to do these calls, and we do the required check before calling it
ubuntu-advantage-tools: maintainer-script-calls-systemctl [postinst:260]
ubuntu-advantage-tools: maintainer-script-calls-systemctl [postinst:263]
6 changes: 2 additions & 4 deletions debian/ubuntu-pro-client.lintian-overrides
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
# We are silencing this issue because of this LP: #1930121
ubuntu-pro-client: command-with-path-in-maintainer-script

# Ubuntu doesn't support sysv init.d
ubuntu-pro-client: package-supports-alternative-init-but-no-init.d-script

# We have made the decision of delivering those files
ubuntu-pro-client: package-installs-apt-preferences

ubuntu-pro-client: possible-bashism-in-maintainer-script
# This is intentional
ubuntu-pro-client: uses-dpkg-database-directly [usr/lib/ubuntu-advantage/apt-esm-json-hook]

0 comments on commit cc85f61

Please sign in to comment.