-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: pro config show
as non-root can be inaccurate
#2809
Comments
5 tasks
dheyay
added a commit
that referenced
this issue
Feb 14, 2024
dheyay
added a commit
that referenced
this issue
Feb 19, 2024
dheyay
added a commit
that referenced
this issue
Feb 21, 2024
dheyay
added a commit
that referenced
this issue
Feb 23, 2024
dheyay
added a commit
that referenced
this issue
Feb 28, 2024
orndorffgrant
pushed a commit
that referenced
this issue
Mar 7, 2024
orndorffgrant
pushed a commit
that referenced
this issue
Mar 14, 2024
orndorffgrant
pushed a commit
that referenced
this issue
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the bug
pro config show
as non-root can be inaccurate when the root user changed a settingExpected behavior
pro config show
as non-root always shows the correct settings, with secrets redactedCurrent behavior
pro config show
as non-root always shows the defaultsTo Reproduce
Please include details on how to reproduce the bug.
sudo pro config set field=value
pro config show
and you won't see the new valueAdditional context
We can't just make user-config.json world-readable (as in #2804) because it may contain proxy secrets. We will likely need a private and public version, similar to our machine-token.json split
The text was updated successfully, but these errors were encountered: