Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: pro config show as non-root can be inaccurate #2809

Closed
orndorffgrant opened this issue Oct 24, 2023 · 0 comments
Closed

Bug: pro config show as non-root can be inaccurate #2809

orndorffgrant opened this issue Oct 24, 2023 · 0 comments
Assignees
Labels
bug something isn't working triaged

Comments

@orndorffgrant
Copy link
Collaborator

Description of the bug

pro config show as non-root can be inaccurate when the root user changed a setting

Expected behavior

pro config show as non-root always shows the correct settings, with secrets redacted

Current behavior

pro config show as non-root always shows the defaults

To Reproduce

Please include details on how to reproduce the bug.

  1. Launch a VM/Container
  2. Run sudo pro config set field=value
  3. Run pro config show and you won't see the new value

Additional context

We can't just make user-config.json world-readable (as in #2804) because it may contain proxy secrets. We will likely need a private and public version, similar to our machine-token.json split

@orndorffgrant orndorffgrant added the bug something isn't working label Oct 24, 2023
dheyay added a commit that referenced this issue Feb 14, 2024
@github-actions github-actions bot mentioned this issue Feb 14, 2024
5 tasks
dheyay added a commit that referenced this issue Feb 19, 2024
dheyay added a commit that referenced this issue Feb 21, 2024
dheyay added a commit that referenced this issue Feb 23, 2024
dheyay added a commit that referenced this issue Feb 28, 2024
orndorffgrant pushed a commit that referenced this issue Mar 7, 2024
orndorffgrant pushed a commit that referenced this issue Mar 14, 2024
orndorffgrant pushed a commit that referenced this issue Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working triaged
Projects
None yet
Development

No branches or pull requests

2 participants