config: make user-config world readable #2804
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow non-root users to see user-config changes performed by root users, we need to make the user-config file world-readable
Comment on lines
+432
to
+436
| if dpkg --compare-versions "$PREVIOUS_PKG_VER" lt "30~"; then | ||
| if [ -f /var/lib/ubuntu-advantage/user-config.json ]; then | ||
| chmod 0644 /var/lib/ubuntu-advantage/user-config.json | ||
| fi | ||
| fi |
There was a problem hiding this comment.
I'd like to continue the pattern of keeping the version migrations in order, so can you move this down after the if dpkg --compare-versions "$PREVIOUS_PKG_VER" lt "29~"; block?
|
Discussion decision: we shouldn't make this file world-readable because it may include proxy secrets. We want to fix the underlying bug properly and not rush it into this release. I'll create an issue then close this. |
|
Issue is here #2809 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
To allow non-root users to see user-config changes performed by root users, we need to make the user-config file world-readable
Test Steps
Verify that the modified integration test and the manual test are passing
Checklist
Does this PR require extra reviews?