Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Outdated references to ua #2849

Closed
s-makin opened this issue Nov 24, 2023 · 4 comments · Fixed by #2928
Closed

Bug: Outdated references to ua #2849

s-makin opened this issue Nov 24, 2023 · 4 comments · Fixed by #2928
Assignees
Labels
bug something isn't working triaged

Comments

@s-makin
Copy link
Contributor

s-makin commented Nov 24, 2023

Description of the bug

Not a bug exactly, but during my survey of the docs I discovered some places that still refer to ua in the code that we should look to update to pro if possible:

  • collect logs page references the created tarfile having the name ua_logs.tar.gz

If these can be updated, we will also need to update the corresponding docs pages:

  • howtoguides/how_to_collect_logs

Edit: The following do not need to be actioned currently, as per discussion below

  • security status command output references ua for the status of the pro client on the
    explanations/how_to_interpret_the_security_status_command page
@s-makin s-makin added the bug something isn't working label Nov 24, 2023
@renanrodrigo
Copy link
Member

The security-status one is, unfortunately, there forever 😨

No, I mean, we must keep JSON keys to assure compatibility, and this response specifically is not versioned :/
We plan to kill this for the future though - there is a plan where everything will go to the API.

@s-makin
Copy link
Contributor Author

s-makin commented Nov 24, 2023

Perfect - thanks for the insight :) Do we need to take any action on the collect logs one, or is that also part of the API plan?

@renanrodrigo
Copy link
Member

nono collect logs can and should be changed

@orndorffgrant
Copy link
Collaborator

Fixed in #2928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working triaged
Projects
None yet
5 participants