Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ua reference docs update #2929

Closed
wants to merge 11 commits into from
Closed

Ua reference docs update #2929

wants to merge 11 commits into from

Conversation

dheyay
Copy link
Contributor

@dheyay dheyay commented Jan 26, 2024

Why is this needed?

Updates the collect logs documentation. Changes ua reference to pro.
Fix for [#2849]

Test Steps

No changes

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

s-makin and others added 9 commits December 12, 2023 14:08
* Convert docs from md to rst
  - Add page anchors for easier referencing
  - Add links.txt file for common links
  - Add snippet files for common reusable text
  - Standardised "how to enable" guides more
  - Moved "enable pro in dockerfile" outside "enable" menu
* Update command in tutorial
* Add fips GCP link
  - Confirmed correct link w/CPC and added to docs where it was missing
@dheyay dheyay closed this Jan 26, 2024
@dheyay dheyay reopened this Jan 26, 2024
@dheyay dheyay changed the base branch from main to docs January 26, 2024 22:35
@dheyay dheyay linked an issue Jan 26, 2024 that may be closed by this pull request
@github-actions github-actions bot added the docs label Jan 29, 2024
Copy link
Contributor

@lucasmoura lucasmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that @dheyay , but since this is tied to a feature that has not yet been released, we need to target the docs-devel branch instead.

We only push to the docs branch what we are ready to publish to the users.

@dheyay dheyay changed the base branch from docs to docs-devel January 29, 2024 20:57
@dheyay
Copy link
Contributor Author

dheyay commented Jan 29, 2024

Thanks for that @dheyay , but since this is tied to a feature that has not yet been released, we need to target the docs-devel branch instead.

We only push to the docs branch what we are ready to publish to the users.

Thanks for letting me know, updated accordingly!

@renanrodrigo
Copy link
Member

@dheyay I think besides changing the target branch, you need to rebase your commit on top of it - otherwise you are bringing several more commits in this PR

* doc: Add security features troubleshooting doc

This adds a document explaining how to troubleshoot the Apparmor and
systemd sandboxing features added to the apt-news service.

* global replace of apparmor with AppArmor

* Review from Sally: wording on the description of how applications can behave under confinement

Co-authored-by: Sally <[email protected]>

* Systemd capitalization

* Turns out it should be systemd instead (lowercase)

---------

Co-authored-by: Sally <[email protected]>
@dheyay
Copy link
Contributor Author

dheyay commented Jan 30, 2024

PR is being closed. Replaced by #2934.

@dheyay dheyay closed this Jan 30, 2024
@renanrodrigo renanrodrigo deleted the ua-reference-docs branch January 31, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Outdated references to ua
6 participants