Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix yaml version after cython 3 #2671

Closed
wants to merge 1 commit into from
Closed

Conversation

CalvoM
Copy link
Contributor

@CalvoM CalvoM commented Jul 27, 2023

Why is this needed?

tox -e py310-test fails since cython upgraded version to 3.
It affects pyyaml 5.4.1. Downgrading to 5.3.1 helped.

Test Steps

tox -e py310-test

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

@github-actions
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@renanrodrigo
Copy link
Member

I could not reproduce this error, but maybe the reason is that I am running Jammy, and the packaged version of pyyaml does not carry the same problem. (And pip does not try to install it again if it is installed in the system I guess)

Besides that, we cannot change this dependency because our py310 tests are targetting Jammy, and 5.3.1 is not available on Jammy.

@CalvoM
Copy link
Contributor Author

CalvoM commented Jul 31, 2023

@renanrodrigo I agree, I meant to remove this PR for your second reason.

@orndorffgrant orndorffgrant deleted the fix-pyyaml-versions branch May 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants