Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pro enable landscape docs #2674

Merged
merged 1 commit into from
Aug 4, 2023
Merged

pro enable landscape docs #2674

merged 1 commit into from
Aug 4, 2023

Conversation

orndorffgrant
Copy link
Collaborator

Docs for #2656

@orndorffgrant orndorffgrant marked this pull request as draft July 27, 2023 19:28
@orndorffgrant orndorffgrant mentioned this pull request Jul 27, 2023
Merged
11 tasks
@orndorffgrant orndorffgrant changed the title wip: landscape docs pro enable landscape docs Aug 1, 2023
@orndorffgrant orndorffgrant marked this pull request as ready for review August 1, 2023 21:09
s-makin
s-makin reviewed Aug 2, 2023
View reviewed changes
Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks really good, thanks! Not many nits, but I do have a few comments and questions

docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/howtoguides/enable_landscape.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
@orndorffgrant
Copy link
Collaborator Author

@s-makin I think I addressed everything - please take another look

s-makin
s-makin approved these changes Aug 4, 2023
View reviewed changes
Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work, thanks Grant :)

@orndorffgrant orndorffgrant merged commit 47d3ab6 into docs-devel Aug 4, 2023
3 checks passed
@orndorffgrant orndorffgrant deleted the docs-devel-landscape branch August 4, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-makin s-makin s-makin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orndorffgrant @s-makin