Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logging: fix calls to logging to use correct logger #2679

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

orndorffgrant
Copy link
Collaborator

Why is this needed?

This PR solves all of our problems because I forgot to change my logging.* calls to use the new logging setup when rebasing on the new logging implementation.

Test Steps

Before:

./tools/test-in-lxd.sh mantic
sudo pro attach $TOKEN
sudo pro enable landscape
# See tons of logging to the console

After: you wont see the logging to the console

Checklist

  • [n/a] I have updated or added any unit tests accordingly
  • [n/a] I have updated or added any integration tests accordingly
  • [n/a] Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

@github-actions
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@lucasmoura lucasmoura merged commit 0d53d90 into main Jul 31, 2023
20 of 23 checks passed
@lucasmoura lucasmoura deleted the logging-fixup branch July 31, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants