Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin esm but only esm #2681

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Pin esm but only esm #2681

merged 2 commits into from
Jul 31, 2023

Conversation

renanrodrigo
Copy link
Member

Why is this needed?

This PR solves all of our problems because it
Fixes: #2580
context is provided in the issue and the internal spec

This is a version of #2664 which does not change the existing FIPS logic - thus, we have both ways to pin repositories (static and dynamic) at the same time. #2680 was created to reflect the next steps of this work.

Test Steps

Run CI and the new sru/ test.

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

renanrodrigo and others added 2 commits July 31, 2023 15:19
This way users who enabled esm will not risk getting automatic updates
for packages if those don't come from the esm repositories, guaranteeing
security patches will not be accidentally removed.

Fixes: #2580

Signed-off-by: Renan Rodrigo <[email protected]>
@github-actions
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues:

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do require documentation changes, but those were not addressed yet.

👍 this comment to confirm that this is correct.

@renanrodrigo
Copy link
Member Author

CI errors unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling ESM app and ESM infra does not set a pin priority for the ESM archives
3 participants