Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use prod environment for magic-attach test #2686

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Aug 1, 2023

Why is this needed?

The staging esm environment is presenting some problems when the apt-helper command tries to verify the credential for some services. We are now switching for the production environment to mitigate that issue

Test Steps

Run the modified integration test

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

The staging esm environment is presenting some problems
when the apt-helper command tries to verify the credential
for some services. We are now switching for the production
environment to mitigate that issue
Copy link
Member

@renanrodrigo renanrodrigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looking good, approving pending CI pass

@renanrodrigo
Copy link
Member

CI errors unrelated, test fixed

@renanrodrigo renanrodrigo merged commit 43f5688 into release Aug 1, 2023
21 of 23 checks passed
@renanrodrigo renanrodrigo deleted the fix-magic-attach-test branch August 1, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants