Release 29 review #2694
Release 29 review #2694
Conversation
debian/source/lintian-overrides
Outdated
| # Lintian doesn't see dh-systemd alternative when building on xenial | ||
| ubuntu-advantage-tools: missing-build-dependency-for-dh_-command dh_systemd_start => dh-systemd | ||
|
|
There was a problem hiding this comment.
This lintian override still overrides the warning when building on xenial - do we care about this?
There was a problem hiding this comment.
@sergiodj we have some lintian warnings that happen on older releases only, and those overrides cause the 'unecessary' messages you saw. How do you think we should best approach this?
There was a problem hiding this comment.
Good question. I believe it's OK leaving the override, then. Although I don't see any of us building the package manually on Xenial, it's still a good idea to document a behaviour that happens there because we still support the distro.
|
Thanks, guys. I left two comments which I hope can clarify questions raised by @renanrodrigo and @orndorffgrant. Otherwise, this PR LGTM. |
Calling systemctl on the postinst script generates a lintian warning. We are replacing it for deb-systemd-invoke to silence it
lucasmoura
force-pushed
the
release-29-review
branch
from
3ed3aee
to
c602233
Compare
|
@sergiodj @orndorffgrant @renanrodrigo updated |
There was a problem hiding this comment.
We got rant in the past because changes to the changelog should be in separate commits than the changes themselves. But if @sergiodj is fine as is, so am I!
No description provided.