Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: mask iscsi service to avoid intermittent errors on github runners #2702

Merged
merged 2 commits into from
Aug 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/attached_commands.feature
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ Feature: Command behaviour when attached to an Ubuntu Pro subscription
Examples: ubuntu release
| release | anbox | esm-apps | cc-eal | cis | fips | fips-update | ros | cis_or_usg | realtime-kernel |
| xenial | no | yes | yes | yes | yes | yes | yes | cis | no |
| bionic | yes | yes | yes | yes | yes | yes | yes | cis | no |
| bionic | no | yes | yes | yes | yes | yes | yes | cis | no |
| focal | yes | yes | no | yes | yes | yes | no | usg | no |
| jammy | yes | yes | no | yes | no | no | no | usg | yes |

Expand Down
11 changes: 11 additions & 0 deletions features/steps/machines.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from behave import given, when
from pycloudlib.instance import BaseInstance # type: ignore

from features.steps.shell import when_i_run_command
from features.steps.ubuntu_advantage_tools import when_i_install_uat
from features.util import (
SUT,
Expand Down Expand Up @@ -88,6 +89,16 @@ def given_a_machine(
series=series, instance=instance
)

if series == "xenial":
# Upgrading open-iscsi to esm version on xenial restarts this service
# This sometimes causes resource errors on github action runners
when_i_run_command(
context,
"systemctl mask iscsid.service",
"with sudo",
machine_name=machine_name,
)

if cleanup:

def cleanup_instance():
Expand Down
Loading