Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uaclient to ubuntupro #2703

Closed
wants to merge 3 commits into from
Closed

uaclient to ubuntupro #2703

wants to merge 3 commits into from

Conversation

orndorffgrant
Copy link
Collaborator

Why is this needed?

This is a proof-of-concept for renaming our python module name from uaclient to ubuntupro while maintaining compatibility for releases prior to 24.04

Before moving forward, we need:

  • approval of new module name
  • approval of having both module names on x,b,f,j,l,m
  • pre-SRU review
  • integration tests using old module name on old releases
  • anything else?

Test Steps

./tools/test-in-lxd.sh xenial
pro help
python3 -c "from ubuntupro import config, status; print(status.status(config.UAConfig()))"
python3 -c "from uaclient import config, status; print(status.status(config.UAConfig()))"

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

@github-actions
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do require documentation changes, but those were not addressed yet.

👍 this comment to confirm that this is correct.

@orndorffgrant orndorffgrant changed the title Uaclient to ubuntupro uaclient to ubuntupro Aug 11, 2023
@orndorffgrant orndorffgrant force-pushed the uaclient-to-ubuntupro branch 2 times, most recently from cfd6618 to af29793 Compare August 11, 2023 18:36
|| [ "$VERSION_ID" = "22.04" ] \
|| [ "$VERSION_ID" = "23.04" ] \
|| [ "$VERSION_ID" = "23.10" ]; then
ln -s ubuntupro /usr/lib/python3/dist-packages/uaclient
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should do this in a pythonic way isntead like import *

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shuold test reverse deps agains this shim

@orndorffgrant orndorffgrant changed the base branch from main to next-v32 January 11, 2024 18:52
@orndorffgrant
Copy link
Collaborator Author

orndorffgrant commented Feb 12, 2024

I did get an informal "yeah that should be okay as long as you test it well against reverse deps" SRU opinion.
We should eventually do this, but this PR is now way out of date and should be closed. It is a good example of what would need to be done.
The main thing we'd want to do differently is use python imports to support the old uaclient name (e.g. actually have an __init__.py that imports everything from ubuntupro) as opposed to the linking method used here. There may be odd side effects with object references with the linking approach.
So I'll close this for now and leave a "Breaks" so that we don't forget about it.

@orndorffgrant
Copy link
Collaborator Author

Breaks: rename uaclient python package name to ubuntupro

@orndorffgrant
Copy link
Collaborator Author

I forgot: "Breaks" only works for merged PRs. Creating issue manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant