-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uaclient
to ubuntupro
#2703
uaclient
to ubuntupro
#2703
Conversation
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references) Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do require documentation changes, but those were not addressed yet. 👍 this comment to confirm that this is correct. |
cfd6618
to
af29793
Compare
af29793
to
81f47bf
Compare
|| [ "$VERSION_ID" = "22.04" ] \ | ||
|| [ "$VERSION_ID" = "23.04" ] \ | ||
|| [ "$VERSION_ID" = "23.10" ]; then | ||
ln -s ubuntupro /usr/lib/python3/dist-packages/uaclient |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should do this in a pythonic way isntead like import *
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we shuold test reverse deps agains this shim
I did get an informal "yeah that should be okay as long as you test it well against reverse deps" SRU opinion. |
Breaks: rename |
I forgot: "Breaks" only works for merged PRs. Creating issue manually. |
Why is this needed?
This is a proof-of-concept for renaming our python module name from uaclient to ubuntupro while maintaining compatibility for releases prior to 24.04
Before moving forward, we need:
Test Steps
Checklist
Does this PR require extra reviews?