[draft] feat: warn/confirm with user if enabling fips downgrades the kernel #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catmsred
force-pushed
the
feature/fips_downgrade_warn
branch
2 times, most recently
from
292f658
to
854aceb
Compare
This change adds a new message prompting the user to confirm if enabling fips downgrades the kernel.
catmsred
force-pushed
the
feature/fips_downgrade_warn
branch
from
854aceb
to
153b457
Compare
|
Will re-open from an upstream branch when this is good to go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new message prompting the user to confirm if enabling fips downgrades the kernel.
Why is this needed?
There have been reports of people enabling FIPS (not realizing it will downgrade their kernel), and having their hardware fail as it needed the new kernel. This change adds an additional warning/prompt if a FIPS enablement is determined to downgrade the kernel.
Jira card: https://warthogs.atlassian.net/browse/SC-1534
Test Steps
TODO: create integration tests
Checklist
Does this PR require extra reviews?