Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message for cloud advertisement #2769

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Oct 3, 2023

Why is this needed?

The attribute of a message for Ubuntu Pro cloud advertisement need to be update, since it is no longer matching the definition on the messages module

Test Steps

Guarantee that the message attributes are being correctly used

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasmoura just a formatting error to fix but then go ahead and merge

@lucasmoura lucasmoura force-pushed the cloud-specific-message-on-fix branch from fd11078 to e23e189 Compare October 3, 2023 20:28
The attribute of a message for Ubuntu Pro cloud
advertisement need to be update, since it is
no longer matching the definition on the messages
module
@lucasmoura lucasmoura force-pushed the cloud-specific-message-on-fix branch from e23e189 to f160c81 Compare October 3, 2023 20:29
@renanrodrigo renanrodrigo merged commit c647fb5 into main Oct 3, 2023
15 checks passed
@renanrodrigo renanrodrigo deleted the cloud-specific-message-on-fix branch October 3, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants