refactor: simplify prerm to not import python #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references) Launchpad Bugs:
Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
orndorffgrant
force-pushed
the
simple-prerm
branch
from
1128e21
to
91b0a7e
Compare
LP: #2021988
orndorffgrant
force-pushed
the
simple-prerm
branch
from
91b0a7e
to
d826d66
Compare
lucasmoura
approved these changes
Oct 16, 2023
| ' | ||
|
|
||
| # This list should be kept up to date with the list of available apt-repo-based services | ||
| for service in anbox cc-eal cis esm-apps esm-infra fips fips-preview fips-updates realtime-kernel ros ros-updates; do |
There was a problem hiding this comment.
I think we also need usg here
There was a problem hiding this comment.
It won't hurt, but is the apt source file named with the presented_as name?
There was a problem hiding this comment.
nope, source-file and key will be ubuntu-cis.list unfortunately 🤡 :upset_cry:
renanrodrigo
approved these changes
Oct 16, 2023
| @@ -661,43 +660,6 @@ def remove_apt_list_files(repo_url, series): | |||
| system.ensure_file_absent(path) | |||
|
|
|||
|
|
|||
| def clean_apt_files(*, _entitlements=None): | |||
There was a problem hiding this comment.
removing code and keeping functionality? good good
|
CI errors are unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LP: #2021988
Why is this needed?
Importing our python module in prerm exposes the packaing script to all the complexity of our python and the risk that a seemingly unrelated change in the python could affect the prerm script.
This happened when we started relying on python3-apt and resulted in LP: #2021988
This PR removes the python import entirely and instead hardcodes the files that need to be removed.
Test Steps
Checklist
Does this PR require extra reviews?