timer: make jobs-status file world readable #2796
Conversation
|
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
| if dpkg --compare-versions "$PREVIOUS_PKG_VER" lt "31~"; then | ||
| if [ -f /var/lib/ubuntu-advantage/jobs-status.json ]; then | ||
| chmod 0644 /var/lib/ubuntu-advantage/jobs-status.json | ||
| fi | ||
| fi | ||
|
|
There was a problem hiding this comment.
Does this change deserve a postinst transition? I think the next time the file is written it will get the new permissions anyway.
There was a problem hiding this comment.
Yeah, I think you are right. My concern was that if the user disabled the timer jobs, we would not update the file, but this is not the case. I will remove this bit together with the manual test
features/collect_logs.feature
Outdated
| @@ -1,5 +1,6 @@ | |||
| Feature: Command behaviour when attached to an Ubuntu Pro subscription | |||
|
|
|||
| @wip | |||
There was a problem hiding this comment.
some @wips left behind 🙃
When running collect-logs as non-root, we might fail trying to collect the jobs-status information. Since there is no private date in this file, we are making it world readable now. Fixes: #2601
lucasmoura
force-pushed
the
make-jobs-status-non-root-readable
branch
from
175d763
to
46e11e6
Compare
|
@orndorffgrant updated |
Why is this needed?
When running collect-logs as non-root, we might fail trying to collect the jobs-status information. Since there is no private date in this file, we are making it world readable now.
Fixes: #2601
Test Steps
Run the modified integration test and the manual test in this PR
Checklist
Does this PR require extra reviews?