Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plan: fix error when variable is not set #2808

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Oct 24, 2023

Why is this needed?

There is a corner case scenario where we end up with a src_pocket_pkgs variable unset. We are now fixing this issue by using a default value for this variable

Test Steps

Run the new integration test

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

There is a corner case scenario where we end up with a
src_pocket_pkgs variable unset. We are now fixing this issue
by using a default value for this variable
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this worked in my test!

@orndorffgrant orndorffgrant merged commit 00bf3dc into release Oct 24, 2023
10 checks passed
@orndorffgrant orndorffgrant deleted the fix-cve-endpoint-issue branch October 24, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants