snap: install snapd as a snap before installing snaps if necessary #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orndorffgrant
force-pushed
the
snap-install-snapd
branch
from
e09fdde
to
2aca7df
Compare
lucasmoura
approved these changes
Oct 25, 2023
renanrodrigo
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
If a service requires installing the
core22snap, and snapd hasn't already bootstrapped itself as a snap (like it does when installing some other snaps), then the snap install will fail. To prevent this, we check before installing the actual snap if snapd is installed as a snap. If it isn't, we runsnap install snapd.Test Steps
New integration test will pass with these changes and fail on the archive version
Checklist
Does this PR require extra reviews?