Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change order of operations when purging services #2812

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Conversation

renanrodrigo
Copy link
Member

@renanrodrigo renanrodrigo commented Oct 26, 2023

Why is this needed?

This PR solves all of our problems because now purge works on generic kernels.

Fixes: #2805

Test Steps

See fixed bug - it does not happen here anymore.

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

Now the downgrades are performed first, and then the kernel is removed.
This way, initramfs runs the non-fips libraries and is able to generate
data for the next boot.

Fixes: #2805

Signed-off-by: Renan Rodrigo <[email protected]>
Using the apt_pkg.Cache to check for the installation information
leads to outdated data and wrong behavior.

Signed-off-by: Renan Rodrigo <[email protected]>
@renanrodrigo
Copy link
Member Author

release-checks will fail because we don't want to list GH bugs that originated from the review in the changelog

Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests passed

@renanrodrigo renanrodrigo merged commit 6ba7c37 into release Oct 27, 2023
16 of 24 checks passed
@renanrodrigo renanrodrigo deleted the purge-order branch October 27, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants