Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add fips-updates tests for Jammy #2821

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Oct 31, 2023

Why is this needed?

Test fips-updates support on bionic.

PS: Note that we need to update the tests once the product definition goes to production

Test Steps

Run the new integration tests

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

@lucasmoura lucasmoura changed the base branch from release to main November 24, 2023 17:05
@lucasmoura lucasmoura force-pushed the add-jammy-fips-updates-test branch 2 times, most recently from 4b7d650 to c742fdf Compare November 24, 2023 20:10
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@@ -466,3 +466,22 @@ Feature: FIPS enablement in cloud based machines
| release | machine_type |
| bionic | aws.generic |
| focal | aws.generic |

Scenario Outline: Attached enable of FIPS in an ubuntu GCP vm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not worrying that much now as we never did in the past, but at some point in time we need to verify the Scenario names... even the ones that are correct could be more descriptive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed

@renanrodrigo renanrodrigo merged commit 312ab9b into main Nov 24, 2023
23 of 25 checks passed
@renanrodrigo renanrodrigo deleted the add-jammy-fips-updates-test branch November 24, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants