unexpected error message is now formatted and takes in an error message #2855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message for Unexpected errors is now a formatted string that takes in an error message so that the original error message is no longer hidden from the end user.
a-dubs
force-pushed
the
better-unexpected-exception-msgs
branch
from
64a822f
to
5c6237f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
The unexpected error message does not reflect accurate log location when run by non root, and also the error message obfuscates the original error message so the end user has no context for what actually went wrong. This PR fixes that.
Changes
messages.UnexpectedErrorfrom aNamedMessageto aFormattedNamedMessageso that it must be formatted with a string representing an exception/error message to give better context on what errors actually occurred.Please Squash this PR with this commit message
cli: improved cli/log message for unexpected errors
Fixes: #2600
Test Steps
Checklist
Does this PR require extra reviews?