Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove livepatch test for WSL #2946

Merged
merged 1 commit into from
Feb 19, 2024
Merged

tests: remove livepatch test for WSL #2946

merged 1 commit into from
Feb 19, 2024

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Feb 15, 2024

Why is this needed?

There is no livepatch support for WSL kernels. Because of that, we are removing the WSL machine type from a specific livepatch test

Test Steps

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

There is no livepatch support for WSL kernels. Because of that, we are
removing the WSL machine type from a specific livepatch test
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@renanrodrigo
Copy link
Member

not merging yet - should this go to main as we probably will run the test suite for WSL as part of the release validation?

@lucasmoura
Copy link
Contributor Author

Indeed, let me change the base

@lucasmoura lucasmoura changed the base branch from next-v32 to main February 16, 2024 13:20
@lucasmoura lucasmoura changed the base branch from main to next-v32 February 16, 2024 13:23
@lucasmoura
Copy link
Contributor Author

@renanrodrigo the problem is that the WSL test infrastructure is not on main :(

@renanrodrigo
Copy link
Member

LOL sorry this is good

@renanrodrigo renanrodrigo merged commit f4fb2ba into next-v32 Feb 19, 2024
21 of 24 checks passed
@renanrodrigo renanrodrigo deleted the fix-wsl-test branch February 19, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants