refactor: some cli module organization in prep for enable api refactor #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references) Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
orndorffgrant
force-pushed
the
some-enable-api-prep
branch
from
ed11189
to
0eb56ad
Compare
lucasmoura
approved these changes
Feb 21, 2024
We cannot name the file "util.py" and "from uaclient.cli import util as cli_util" because there is a bug in python where python will confuse the two modules even if one is renamed at import time.
orndorffgrant
force-pushed
the
some-enable-api-prep
branch
from
0eb56ad
to
17a9841
Compare
renanrodrigo
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This just organizes the enable cli code into its own module in preparation for the bigger enable refactor coming soon.
Test Steps
everything should still work
Checklist
Does this PR require extra reviews?