Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-attach: make error message clearer #2992

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

renanrodrigo
Copy link
Member

Why is this needed?

This PR solves all of our problems because now we tell people to run auto-attach after upgrades, and users are seeing the generic error.
When a machine tries to auto-attach and the contract server returns an error, print hints on what could have happened together with the error details.

Test Steps

Integration test is good, can be tried in any cloud manually.

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

Copy link

github-actions bot commented Mar 14, 2024

🌎 This PR changes translatable messages. 🌏

Please select which scenarios apply. For further explanation, please read our policy on message changes.

  • New messages are being added.
    • We will ask translators to take a look and add translations if they have time, but it will not block this PR.
  • Existing messages are being changed.
    • ⚠️ Please add a comment with justification of why messages are being altered.
    • If the changes are trivial (e.g. a typo fix), then translations must be preserved.
    • If the changes are substantial, then we will ask translators to take a look and update translations if they have time, but it will not block this PR.
  • Existing messages are being deleted.
    • No special action needed.

Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@renanrodrigo
Copy link
Member Author

Please add a comment with justification of why messages are being altered

Updating the message is the whole point of this PR

If the changes are substantial, then we will ask translators to take a look and update translations if they have time, but it will not block this PR.

No translation for this one yet anyway.

Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@renanrodrigo
Copy link
Member Author

rebased and got rid of conflicts

When a machine tries to auto-attach and the contract server returns an
error, print hints on what could have happened together with the error
details.

Signed-off-by: Renan Rodrigo <[email protected]>
@renanrodrigo
Copy link
Member Author

re rebased and the maybe line is gone; merging

@renanrodrigo renanrodrigo merged commit cb0d13b into main Mar 21, 2024
16 checks passed
@renanrodrigo renanrodrigo deleted the auto-attach-better-error branch March 21, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants