-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto-attach: make error message clearer #2992
Conversation
🌎 This PR changes translatable messages. 🌏 Please select which scenarios apply. For further explanation, please read our policy on message changes.
|
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references) Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
Updating the message is the whole point of this PR
No translation for this one yet anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
0562dd7
to
0755ff3
Compare
rebased and got rid of conflicts |
0755ff3
to
1b27ddb
Compare
When a machine tries to auto-attach and the contract server returns an error, print hints on what could have happened together with the error details. Signed-off-by: Renan Rodrigo <[email protected]>
1b27ddb
to
ab4dd74
Compare
re rebased and the maybe line is gone; merging |
Why is this needed?
This PR solves all of our problems because now we tell people to run
auto-attach
after upgrades, and users are seeing the generic error.When a machine tries to auto-attach and the contract server returns an error, print hints on what could have happened together with the error details.
Test Steps
Integration test is good, can be tried in any cloud manually.
Checklist
Does this PR require extra reviews?