fix: wait for cloud-init.service to fully activate #3020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uaclient/tests/test_lib_daemon.py
Outdated
| @@ -54,6 +71,7 @@ def test_wait_for_cloud_config( | |||
| active_state_side_effect, | |||
| expected_sleep_calls, | |||
| ): | |||
| print(active_state_side_effect) | |||
There was a problem hiding this comment.
This one is not needed anymore (:
Once the systemd constraint on After cloud-config.service was removed, there are situations where cloud-config.service runs so long after pro that the python code that waits for cloud-config.service to finish activating is being bypassed as if cloud-init isn't on the system. This change forces pro to wait for cloud-config to finish if cloud-init is running at all.
catmsred
force-pushed
the
fix/wait_on_cloud-init
branch
from
a169227
to
b4b8565
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the systemd constraint on After cloud-config.service was removed, there are situations where cloud-config.service runs so long after pro that the python code that waits for cloud-config.service to finish activating is being bypassed as if cloud-init isn't on the system. This change forces pro to wait for cloud-config to finish if cloud-init is running at all.
Fixes #3000
Please Squash this PR with this commit message
Checklist
Does this PR require extra reviews?