Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add scenario to assure custom APT configuration is respected #3150

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

renanrodrigo
Copy link
Member

@renanrodrigo renanrodrigo commented Jun 11, 2024

Why is this needed?

This PR solves all of our problems because it ensures custom APT configuration is respected by the pro client when done globally, whether through proper system configuration or using environment variables.

Test Steps

CI should be green, as the new integration test runs on X/N lxd-container

Checklist

Does this PR require extra reviews?

  • Yes
  • No

Copy link

github-actions bot commented Jun 11, 2024

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: Documentation changes addressed in #3151

👍 this comment to confirm that this is correct.

@renanrodrigo
Copy link
Member Author

renanrodrigo commented Jun 11, 2024

I chose Xenial and Noble because

  • Xenial older, Noble newest
  • Xenial to Jammy will have APT behaving exactly the same, no need to run them all IMHO
  • Noble carries the new deb822 config files, and we make sure it still works even there

Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

features/security_status.feature Outdated Show resolved Hide resolved
@orndorffgrant orndorffgrant merged commit ad1c364 into main Jun 20, 2024
25 of 26 checks passed
@orndorffgrant orndorffgrant deleted the apt-config-tests branch June 20, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants