Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: remove service list from help output #3172

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

renanrodrigo
Copy link
Member

@renanrodrigo renanrodrigo commented Jun 18, 2024

Why is this needed?

This PR solves all of our problems because we don't call the backends anymore when just running help.

OOOOOOH but we are missing the service list now
yes
that's the point
it is not there in the new UX design, and getting rid of it now prevents problems

Fixes: #3126

Test Steps

Disconnect your system
Run pro help or pro -h or pro --help and see it works and has less content
Integration tests are smaller too


  • (un)check this to re-run the checklist action

The new UI design will not have a service list, and removing this now
will make sure we don't call the contracts server when running help.

Fixes: #3126

Signed-off-by: Renan Rodrigo <[email protected]>
Copy link

github-actions bot commented Jun 18, 2024

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

If we are telling people to run help, just run help for them and let
them see the content - and don't error out because of that.

Signed-off-by: Renan Rodrigo <[email protected]>
Copy link
Contributor

@dheyay dheyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood

Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you thank you this is good

@orndorffgrant orndorffgrant merged commit 741ec61 into next-v34 Jun 18, 2024
25 of 26 checks passed
@orndorffgrant orndorffgrant deleted the make-cli-great-again branch June 18, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: pro --help reaches out to the contract server
4 participants