-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
help: remove service list from help output #3172
Conversation
The new UI design will not have a service list, and removing this now will make sure we don't call the contracts server when running help. Fixes: #3126 Signed-off-by: Renan Rodrigo <[email protected]>
PR ChecklistHow to use this checklistHow to use this checklistPR AuthorFor each section, check a box when it is true. PR ReviewerCheck that the PR checklist action did not fail. Bug ReferencesConfirm
How to properly reference fixed bugs
Test UpdatesUnit Tests
Integration Tests
Documentation
Does this PR require review from someone outside the core ubuntu-pro-client team?
|
If we are telling people to run help, just run help for them and let them see the content - and don't error out because of that. Signed-off-by: Renan Rodrigo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks goood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you thank you this is good
Why is this needed?
This PR solves all of our problems because we don't call the backends anymore when just running
help
.OOOOOOH but we are missing the service list now
yes
that's the point
it is not there in the new UX design, and getting rid of it now prevents problems
Fixes: #3126
Test Steps
Disconnect your system
Run
pro help
orpro -h
orpro --help
and see it works and has less contentIntegration tests are smaller too