typing: add no_implicit_optional lint lint #3173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicit optional types are preferred and the default in mypy >= 0.980[1]. Add the config to check for this and fix any instance of the lint error. References: [1] https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_optional
renanrodrigo
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
@aciba90 thanks! LGTM
I would suggest changing the base branch to next-v34 as main is currently frozen for release, but I think this is simple enough to make it to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This PR solves all of our problems because it enforces a newer and better default for a lint check.
Test Steps