Remove dead functionality from the codebase #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now behave is way more sane to run in the CLI, and the credentials file to be used is protest.yaml Signed-off-by: Renan Rodrigo <[email protected]>
Removing the update_contract_info function, its respective job, the is_contract_changed method and the CONTRACT_REFRESH_WARNING notice. None of this functionality is being called anywhere in the code. Fixes: #3058 Signed-off-by: Renan Rodrigo <[email protected]>
PR ChecklistHow to use this checklistHow to use this checklistPR AuthorFor each section, check a box when it is true. PR ReviewerCheck that the PR checklist action did not fail. Bug ReferencesConfirm
How to properly reference fixed bugs
Test UpdatesUnit Tests
Integration Tests
Documentation
Does this PR require review from someone outside the core ubuntu-pro-client team?
|
lucasmoura
approved these changes
Jun 18, 2024
orndorffgrant
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This PR solves all of our problems because dead code is dead, and should be buried in the past.
The functionality can be restored from git history in the future if we want to see it again. creepy right.
Fixes: #3058
Test Steps
Everything should be working normal, from tox to behave, as this is only removing unused functionality.