docs: update unit test documentation #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good, just needs a rebase and conflict resolution |
lucasmoura
force-pushed
the
fix-dev-docs-test-setup
branch
from
0afdcbb
to
4d1138e
Compare
|
@orndorffgrant done |
s-makin
approved these changes
Jul 24, 2024
dev-docs/howtoguides/unit_testing.md
Outdated
|
|
||
| First, run the script to install and configure `pyenv`, and the `tox` dependencies: | ||
| All unit and lint tests are run using `tox`. However, before we can run our tests, we need to | ||
| install some package dependencies. This can be achieve through our Makefile script. To install those |
There was a problem hiding this comment.
Suggested change
| install some package dependencies. This can be achieve through our Makefile script. To install those | |
| install some package dependencies. This can be achieved through our Makefile script. To install those |
We are now telling the user to run make deps before calling tox and also removing any mention to pyenv, as we don't use that anymore for our tests. Fixes: #2892
lucasmoura
force-pushed
the
fix-dev-docs-test-setup
branch
from
4d1138e
to
9642f11
Compare
|
@s-makin fixed |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
We are now telling the user to run make deps before calling tox and also removing any mention to pyenv, as we don't use that anymore for our tests.