Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Mantic from the codebase+tests #3267

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Remove Mantic from the codebase+tests #3267

merged 4 commits into from
Sep 3, 2024

Conversation

renanrodrigo
Copy link
Member

Why is this needed?

This PR solves all of our problems because mantic is EOL and we want to remove it. To cover the gap left behind, some tests got noble and some tests got oracular versions instead.

To sort out some tests, this
Fixes: #3132

Test Steps

All about integration tests here - every new added noble/oracular test should pass.

  • (un)check this to re-run the checklist action

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited by renanrodrigo
Loading

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

@renanrodrigo
Copy link
Member Author

Agreed with @lucasmoura that this should only land after #3268 is merged, and we rebase on top of that

dheyay
dheyay approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@dheyay dheyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval since we this is dependent on the other tests PR to be merged first.
Also, I just had a question about the inclusion of oracular in some tests, are the tests to which the non-lts release is added, selected on some metric?

Thanks @renanrodrigo

orndorffgrant
orndorffgrant approved these changes Aug 30, 2024
View reviewed changes
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion that we add oracular to a couple more places where we're removing mantic - preemptively approving. Thanks for doing this one - this is tedious!

uaclient/upgrade_lts_contract.py Show resolved Hide resolved
@renanrodrigo
chore: remove mantic references from the codebase
eebbfef 
Signed-off-by: Renan Rodrigo <[email protected]>
@renanrodrigo
apt: always ensure the ESM cache is present
b3760e5 
We used to build the base file/folder structure when updating the local
APT cache. However, in some cases, the cache may be accessed before it
is created. In the past an exception was raised and we catched + ignored
it, but from Noble onward this turned to a simple warning on the APT
side.

We fix it by always ensuring the structure is present when trying to
fetch the cache.

Fixes: #3132

Signed-off-by: Renan Rodrigo <[email protected]>
@renanrodrigo
tests: Change mantic tests in behave to noble/oracular
eab89a8 
Mantic is now EOL, so we are removing the mantic tests from the
acceptance suite.
- If the test was a general one, we add noble/oracular.
- If it was a test which targets interim releases, we add oracular.
- Some oracular tests are commented out until the backend+cloud is
  sorted out.

Signed-off-by: Renan Rodrigo <[email protected]>
@renanrodrigo
Copy link
Member Author

Changes here are not related to the changeset - the same fix problems as always + azure fips

@renanrodrigo renanrodrigo merged commit 452b127 into next-v35 Sep 3, 2024
21 of 24 checks passed
@renanrodrigo renanrodrigo deleted the byemantic branch September 3, 2024 20:55
@renanrodrigo renanrodrigo mentioned this pull request Sep 3, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheyay dheyay dheyay approved these changes

@orndorffgrant orndorffgrant orndorffgrant approved these changes

@lucasmoura lucasmoura Awaiting requested review from lucasmoura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pro security-status emits warning if ESM cache doesn't exist
3 participants
@renanrodrigo @orndorffgrant @dheyay