Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include generated documentation for the CLI commands #3286

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

renanrodrigo
Copy link
Member

Why is this needed?

This PR solves all of our problems because now we have a CLI reference, and it is generated from the actual source code.

Test Steps

check the docs


  • (un)check this to re-run the checklist action

@github-actions github-actions bot added the docs label Aug 29, 2024
@renanrodrigo renanrodrigo force-pushed the include-generated-cli branch 3 times, most recently from 1175008 to a595703 Compare August 29, 2024 05:08
@renanrodrigo
Copy link
Member Author

Readthedocs is complaining about my indentation... @s-makin would you know why? How to fix that, if needed?

Besides that, there are two words (customizable, artifacts) which are in American, and if I translate those to English it becomes inconsistent with all messages in the client itself hahahaha :( so I added them to the wordlist. Do we prefer this small inconsistency in the docs, or in the client itself? OR should we rewrite the whole client in British?

@renanrodrigo renanrodrigo mentioned this pull request Aug 29, 2024
1 task
@renanrodrigo
Copy link
Member Author

(I could remove the attach config example completely from the command description, and reformat the security status list of items to use * instead of - - just saying)

@s-makin
Copy link
Contributor

s-makin commented Aug 29, 2024

Readthedocs is complaining about my indentation... @s-makin would you know why? How to fix that, if needed?

Besides that, there are two words (customizable, artifacts) which are in American, and if I translate those to English it becomes inconsistent with all messages in the client itself hahahaha :( so I added them to the wordlist. Do we prefer this small inconsistency in the docs, or in the client itself? OR should we rewrite the whole client in British?

Re: the spelling inconsistency, I think since it's coming from the source code it's better for us to just add those spelling exceptions than to start refactoring the codebase into GB English 😬

Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments/suggestions - hopefully I've caught all the places that could be causing build issues on RTD, but if not, double check that all your bullet/numbered/unnumbered lists have an empty line before and after, and that anything you want rendered as a code block has a .. code-block:: directive. That should fix the errors you saw :) I can do a check of the rendering after the RTD builds properly.

docs/references/commands.txt Show resolved Hide resolved
docs/references/commands.txt Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
@renanrodrigo
Copy link
Member Author

Breaks: autogenerated CLI documentation is unformatted

@renanrodrigo
Copy link
Member Author

@s-makin addressed all comments according to what we spoke about. All good with the RTD build now. Please take another look when possible.

Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more little nits to make the rendering consistent.

Also, there's a broken link to the IRC channel somewhere. I tested the link and it does appear to just hang forever and doesn't even time out. Not sure why?

docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
@orndorffgrant
Copy link
Collaborator

orndorffgrant commented Sep 9, 2024

I would like to eventually see a table of cli flags with descriptions for each command (example), but that can be a future iteration. This is already a great improvement thank you!

@renanrodrigo
Copy link
Member Author

@orndorffgrant I like the suggestion and I could easily add it now. Not doing because it would look horrible :D
We need to sort out the formatting thing first, and then we gain some... flexibility? Will add this to the backlog after this change lands.

@renanrodrigo
Copy link
Member Author

Breaks: autogenerated CLI reference could include flags and options in the output

@renanrodrigo
Copy link
Member Author

@s-makin addressed all your points, please take another look

Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one final nitpick to make the bullet lists consistently formatted.

Ideally, I would also like to see some brief instructions on how the autogeneration works in the devdocs (where the autogeneration happens, what files to change, etc). Since we know we'll have follow-up work on this, and we know it won't be imminently, it would be good to have that documented for Future Us. I'd be ok with us including that in a separate PR, though, if we don't want to hold this one up.

docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
docs/references/commands.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@dheyay dheyay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except some remaining minor nits from @s-makin

@renanrodrigo
Copy link
Member Author

renanrodrigo commented Sep 15, 2024

@s-makin last review addressed, I can type the instructions on generating the content in this PR here. I see that there is also no dev docs for the autogenerated API commands, and both of those would be important for the release process. I vote for merging this one (together with #3282 for the sake of mergeness, and then I'll open a separate one (soon) including instructions on how to use these tools to make sure everything is up to date prior to releasing.

@s-makin
Copy link
Contributor

s-makin commented Sep 16, 2024

I vote for merging this one (together with #3282 for the sake of mergeness, and then I'll open a separate one (soon) including instructions on how to use these tools to make sure everything is up to date prior to releasing.

Sounds good to me :) let's do that

Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the work on this!

@s-makin s-makin merged commit 064896b into docs Sep 16, 2024
7 checks passed
@renanrodrigo renanrodrigo deleted the include-generated-cli branch September 16, 2024 14:12
@renanrodrigo
Copy link
Member Author

Hmm the breaks thing didn't trigger because merging to docs
I'll raise the issues by hand in a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants