cli: add a wrap function which considers colored text #3304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ChecklistHow to use this checklistHow to use this checklistPR AuthorFor each section, check a box when it is true. PR ReviewerCheck that the PR checklist action did not fail. Bug ReferencesNone. Confirm
How to properly reference fixed bugs
Test UpdatesUnit Tests
Integration Tests
Documentation
Does this PR require review from someone outside the core ubuntu-pro-client team?
|
renanrodrigo
force-pushed
the
color-wrap
branch
2 times, most recently
from
9a5f018
to
95390ea
Compare
orndorffgrant
approved these changes
Sep 17, 2024
Cannot rely on textwrap because of colors: the length of colored strings will be bigger than the actual space these take on screen. We add a function to get the length without the colors, and a wrap_text function which relies on that. Signed-off-by: Renan Rodrigo <[email protected]>
Signed-off-by: Renan Rodrigo <[email protected]>
renanrodrigo
force-pushed
the
color-wrap
branch
from
95390ea
to
d85f895
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This PR solves all of our problems because with this we are able to wrap text even if there are color codes in it, using the full space on screen. This is mostly useful for tables/blocks.
This is based on #3294 and should land after that.
Test Steps
unit tests added for the functionality