Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Pretty processor for logs #3322

Merged
merged 1 commit into from
Oct 22, 2024
Merged

tools: Pretty processor for logs #3322

merged 1 commit into from
Oct 22, 2024

Conversation

dheyay
Copy link
Contributor

@dheyay dheyay commented Sep 20, 2024

Why is this needed?

This PR solves all of our problems because we manually scroll and toil to look at logs.

This makes it easier (hopefully) ->

Usage example
python3 tools/process_logs.py optional_log_level -f optional_file

Usage: process_logs.py [OPTIONS] [[ERROR|DEBUG|WARNING]]

Options:
  -f, --file TEXT     Log file to process
  -p, --pattern TEXT  Regular expression pattern to filter logs
  --help              Show this message and exit

Currently draft since this can be made much better for our uses.

Test Steps

N/A


  • (un)check this to re-run the checklist action

Copy link

github-actions bot commented Sep 20, 2024

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

None.

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

@dheyay dheyay force-pushed the log-tools branch 2 times, most recently from 595c6c3 to 11a0999 Compare September 23, 2024 21:00
@dheyay dheyay marked this pull request as ready for review September 23, 2024 21:01
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of our process to get ready for v35, I have rebased next-v35 onto main. As a result, next-v35 is now obsolete. Please rebase this on main and target the PR to main.

@dheyay dheyay changed the base branch from next-v35 to main September 30, 2024 18:02
@dheyay
Copy link
Contributor Author

dheyay commented Sep 30, 2024

Rebased on main @orndorffgrant

@dheyay dheyay changed the base branch from main to next-v36 October 8, 2024 20:39
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent and a great starting point for us to add new features to it as needed. Thank you!!

@orndorffgrant orndorffgrant merged commit bf79034 into next-v36 Oct 22, 2024
20 of 25 checks passed
@orndorffgrant orndorffgrant deleted the log-tools branch October 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants