Add links and alignment functionality to the CLI formatter tooling #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR ChecklistHow to use this checklistHow to use this checklistPR AuthorFor each section, check a box when it is true. PR ReviewerCheck that the PR checklist action did not fail. Bug ReferencesNone. Confirm
How to properly reference fixed bugs
Test UpdatesUnit Tests
Integration Tests
Documentation
Does this PR require review from someone outside the core ubuntu-pro-client team?
|
renanrodrigo
changed the title
1 task
|
Bad, bad Fix CI |
Some of our tables may have columns which are right-aligned instead of left-aligned. None of them are centered yet but this would follow easily if we need it. Signed-off-by: Renan Rodrigo <[email protected]>
Signed-off-by: Renan Rodrigo <[email protected]>
Add a function to create rendered links for the terminal, and logic to ignore anything but the text when calculating the length or printing to a non-tty stdout Signed-off-by: Renan Rodrigo <[email protected]>
renanrodrigo
force-pushed
the
more-cli-and-such
branch
from
f02b33e
to
9708aa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is this needed?
This PR solves all of our problems because it implements some needed niceties on top of the CLI tools we are working on.
This is based on #3323 and should be merged after that. (It is the same context though, I didn't push the commits there because that one is kinda approved I guess)
Test Steps
Unit tests cover functionality, integration will come because the new CLI commands depend on this.