-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python3-pkg-resources dependency on Oracular #3337
Conversation
PR ChecklistHow to use this checklistHow to use this checklistPR AuthorFor each section, check a box when it is true. PR ReviewerCheck that the PR checklist action did not fail. Bug References
Confirm
How to properly reference fixed bugs
Test UpdatesUnit Tests
Integration Tests
Documentation
Does this PR require review from someone outside the core ubuntu-pro-client team?
|
debian/rules
Outdated
@@ -49,7 +61,7 @@ endif | |||
endif | |||
|
|||
override_dh_gencontrol: | |||
echo "extra:Depends=$(APT_PKG_DEPS) $(DISTRO_INFO_DEPS)" >> debian/ubuntu-pro-client.substvars | |||
echo "extra:Depends=$(APT_PKG_DEPS) $(DISTRO_INFO_DEPS) ${PYTHON3_PKG_RESOURCES}" >> debian/ubuntu-pro-client.substvars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we're using curly braces for this one when we use parentheses for the other similar variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, they are now consistent
We don't need this package dependency on Oracular and for the upcoming releases. Since we are on ubuntu-minimal, we are now removing that dependency from Oracular forward to not bring an unneeded dependency into our minimal images. LP: #2083665
9b08169
to
cbeefac
Compare
Why is this needed?
We don't need this package dependency on Oracular and for the upcoming releases. Since we are on ubuntu-minimal, we are now removing that dependency from Oracular forward to not bring an unneeded dependency into our minimal images.
LP: #2083665
Test Steps
Check that the control file for packages before Oracular include
python3-pkg-resources
and the Oracular package doesn't