Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python3-pkg-resources dependency on Oracular #3337

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Oct 7, 2024

Why is this needed?

We don't need this package dependency on Oracular and for the upcoming releases. Since we are on ubuntu-minimal, we are now removing that dependency from Oracular forward to not bring an unneeded dependency into our minimal images.

LP: #2083665

Test Steps

Check that the control file for packages before Oracular include python3-pkg-resources and the Oracular package doesn't


  • (un)check this to re-run the checklist action

Copy link

github-actions bot commented Oct 7, 2024

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

debian/rules Outdated
@@ -49,7 +61,7 @@ endif
endif

override_dh_gencontrol:
echo "extra:Depends=$(APT_PKG_DEPS) $(DISTRO_INFO_DEPS)" >> debian/ubuntu-pro-client.substvars
echo "extra:Depends=$(APT_PKG_DEPS) $(DISTRO_INFO_DEPS) ${PYTHON3_PKG_RESOURCES}" >> debian/ubuntu-pro-client.substvars
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we're using curly braces for this one when we use parentheses for the other similar variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, they are now consistent

We don't need this package dependency on Oracular and for
the upcoming releases. Since we are on ubuntu-minimal, we
are now removing that dependency from Oracular forward
to not bring an unneeded dependency into our minimal images.

LP: #2083665
@orndorffgrant orndorffgrant enabled auto-merge (rebase) October 9, 2024 14:10
@orndorffgrant orndorffgrant merged commit 2f594f4 into main Oct 9, 2024
11 of 15 checks passed
@orndorffgrant orndorffgrant deleted the python3-pkg-resources-fix branch October 9, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants