Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #3354

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix tests #3354

merged 2 commits into from
Oct 24, 2024

Conversation

lucasmoura
Copy link
Contributor

@lucasmoura lucasmoura commented Oct 21, 2024 •
edited by orndorffgrant
Loading

Why is this needed?

Fix some integration tests for the release

Test Steps

Check that the affected integration tests are passing

  • (un)check this to re-run the checklist action

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited by orndorffgrant
Loading

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

None.

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

orndorffgrant
orndorffgrant reviewed Oct 22, 2024
View reviewed changes
features/retry_auto_attach.feature
@@ -117,19 +117,14 @@ Feature: auto-attach retries periodically on failures

Examples: ubuntu release
| release | machine_type |
| xenial | aws.generic |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto-attach retries should work on aws, right? What changed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I should read commit messages before commenting 🤦

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then, if the mechanism for triggering retries on aws is different now, we can't rely on the gcp/azure tests for it right?
I think we need an aws specific test for this feature now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@lucasmoura
tests: update aws setup for retry auto-attach
70e073d 
On AWS, we no longer try to run auto-attach if we run the
ua-auto-attach systemd job. Because of that, the setup
we are using for the retry auto-attach test no longer works
for AWS. We are now using a different setup for AWS
orndorffgrant
orndorffgrant approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@orndorffgrant orndorffgrant enabled auto-merge (rebase) October 24, 2024 14:17
@orndorffgrant orndorffgrant merged commit 32c5bb6 into main Oct 24, 2024
19 of 25 checks passed
@orndorffgrant orndorffgrant deleted the fix-tests branch October 24, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renanrodrigo renanrodrigo renanrodrigo approved these changes

@orndorffgrant orndorffgrant orndorffgrant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmoura @orndorffgrant @renanrodrigo