Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GCP): Add minimal image license codes #3359

Closed

Conversation

kajiya3141
Copy link
Member

We (CPC) have recently started building Minimal Pro images (as well as the usual "Base" images). This commit adds the new license codes to the appropriate suites in gcp.py:GCP_LICENSES.

We have recently started building Minimal Pro images (as well as the
usual "Base" images). This commit adds the new licenses to the
appropriate suites in GCP_LICENSES.
@kajiya3141
Copy link
Member Author

I wasn't able to run the unit tests locally due to a weird apt_pkg error. I'll keep an eye on the CI runner though 👀

@orndorffgrant
Copy link
Collaborator

Thanks @kajiya3141 !
Do you need this somewhat quickly? somewhat quickly (e.g. mid november) is about the best we can do :)
If yes, can you please rebase/retarget the PR against the main branch so we can squeeze it in the ongoing release

@kajiya3141
Copy link
Member Author

Hey Grant! Thanks for the speedy reply 😄

No we don't need it particularly quickly, as soon as you can manage will be fine :)
I'll rebase against main now...

@kajiya3141
Copy link
Member Author

Closed in favour of #3360 👀

@kajiya3141 kajiya3141 closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants