-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create pull_request_template.md #112
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change @goodylili, it looks great! I have just a couple of small comments/suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great already, some suggestions to make it even better :-)
Hi @goodylili, I just wanted to follow up to see how this is going. I noticed that you've marked all the review comments as resolved. Once you've pushed your changes, please feel free to request re-review to let us know it's ready :) |
Description
The problem:
We are currently lacking a nicely-formatted Pull Request template.
What is needed:
It should include:
a link to the Contributor License Agreement
a reminder to sign the CLA, if the contributor has not already
Fixes: #1234 as a reminder to include the corresponding issue number, if the PR fixes an open issue
a space for a commit message that the author wants to be applied to a squash merge
Suggestions:
We currently don't have a PR template at all. There is some helpful guidance in the GitHub documentation about creating PR templates.
Related Issue
Checklist