Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create pull_request_template.md #112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

goodylili
Copy link

Description

The problem:

We are currently lacking a nicely-formatted Pull Request template.

What is needed:

It should include:

a link to the Contributor License Agreement
a reminder to sign the CLA, if the contributor has not already
Fixes: #1234 as a reminder to include the corresponding issue number, if the PR fixes an open issue
a space for a commit message that the author wants to be applied to a squash merge
Suggestions:

We currently don't have a PR template at all. There is some helpful guidance in the GitHub documentation about creating PR templates.


Related Issue


Checklist

  • I have read and followed the Ubuntu Server contributing guide.
  • I have signed the Contributor License Agreement (CLA).
  • My changes are well-documented, and I have updated the documentation as needed.
  • My pull request is linked to an existing issue (if applicable).
  • I have tested my changes, and they work as expected.
  • New and existing unit tests pass locally with my changes.

@goodylili goodylili marked this pull request as ready for review January 11, 2025 11:33
Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change @goodylili, it looks great! I have just a couple of small comments/suggestions

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
Copy link
Contributor

@cpaelzer cpaelzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great already, some suggestions to make it even better :-)

.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
.github/pull_request_template.md Show resolved Hide resolved
@goodylili goodylili closed this Jan 16, 2025
@goodylili goodylili deleted the patch-1 branch January 16, 2025 10:35
@goodylili goodylili restored the patch-1 branch January 16, 2025 10:45
@goodylili goodylili reopened this Jan 16, 2025
@s-makin
Copy link
Collaborator

s-makin commented Jan 21, 2025

Hi @goodylili, I just wanted to follow up to see how this is going. I noticed that you've marked all the review comments as resolved. Once you've pushed your changes, please feel free to request re-review to let us know it's ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Admin: Create a PR template
3 participants