Insert isValid function as an extention for colorjs.io #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also stubbed in a tracer-bullet.js to quickly verify code rather than running and console logging from the web page.
✅ Deploy Preview for prismcolor-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reverted all previous validate-color routines to favor an approach where we can share improvements in a PR to colorjs.io.
This PR lifts portions of code from colorjs.io npm package that was private so we could expose and add an isValid function.
Also stubbed in a test-utils/tracer-bullet.js that can be called with
node test-utils/tracer-bullets.jsto quickly smoke test code (rather than running and console logging from the web page every time).