Merge pull request #145 from trinitiwowka/hotfix-logEvent-name

fix:replace name to eventName in logEvent definition
capacitor-community · Apr 21, 2024 · 0c64cd2 · 0c64cd2
2 parents a7d62bc + ea5992d
commit 0c64cd2
Show file tree

Hide file tree

Showing 6 changed files with 59 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -333,12 +333,12 @@ getProfile<T extends Record<string, unknown>>(options: { fields: readonly string
 ### logEvent(...)
 
 ```typescript
-logEvent(options: { name: string; }) => Promise<void>
+logEvent(options: { eventName: string; }) => Promise<void>
 ```
 
-| Param         | Type                           |
-| ------------- | ------------------------------ |
-| **`options`** | <code>{ name: string; }</code> |
+| Param         | Type                                |
+| ------------- | ----------------------------------- |
+| **`options`** | <code>{ eventName: string; }</code> |
 
 --------------------
 

diff --git a/ios/Plugin.xcodeproj/project.pbxproj b/ios/Plugin.xcodeproj/project.pbxproj
@@ -284,11 +284,19 @@
 				"${PODS_ROOT}/Target Support Files/Pods-PluginTests/Pods-PluginTests-frameworks.sh",
 				"${BUILT_PRODUCTS_DIR}/Capacitor/Capacitor.framework",
 				"${BUILT_PRODUCTS_DIR}/CapacitorCordova/Cordova.framework",
+				"${PODS_XCFRAMEWORKS_BUILD_DIR}/FBAEMKit/FBAEMKit.framework/FBAEMKit",
+				"${PODS_XCFRAMEWORKS_BUILD_DIR}/FBSDKCoreKit/FBSDKCoreKit.framework/FBSDKCoreKit",
+				"${PODS_XCFRAMEWORKS_BUILD_DIR}/FBSDKCoreKit_Basics/FBSDKCoreKit_Basics.framework/FBSDKCoreKit_Basics",
+				"${PODS_XCFRAMEWORKS_BUILD_DIR}/FBSDKLoginKit/FBSDKLoginKit.framework/FBSDKLoginKit",
 			);
 			name = "[CP] Embed Pods Frameworks";
 			outputPaths = (
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Capacitor.framework",
 				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/Cordova.framework",
+				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBAEMKit.framework",
+				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBSDKCoreKit.framework",
+				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBSDKCoreKit_Basics.framework",
+				"${TARGET_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}/FBSDKLoginKit.framework",
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 			shellPath = /bin/sh;

diff --git a/ios/Plugin/Plugin.swift b/ios/Plugin/Plugin.swift
@@ -123,8 +123,8 @@ public class FacebookLogin: CAPPlugin {
     }
 
     @objc func logEvent(_ call: CAPPluginCall) {
-        if let name = call.getString("name") {
-            AppEvents.shared.logEvent(AppEvents.Name(name))
+        if let eventName = call.getString("eventName") {
+            AppEvents.shared.logEvent(AppEvents.Name(eventName))
         }
 
         call.resolve()

diff --git a/ios/Podfile.lock b/ios/Podfile.lock
@@ -0,0 +1,43 @@
+PODS:
+  - Capacitor (5.0.0):
+    - CapacitorCordova
+  - CapacitorCordova (5.0.0)
+  - FBAEMKit (16.1.3):
+    - FBSDKCoreKit_Basics (= 16.1.3)
+  - FBSDKCoreKit (16.1.3):
+    - FBAEMKit (= 16.1.3)
+    - FBSDKCoreKit_Basics (= 16.1.3)
+  - FBSDKCoreKit_Basics (16.1.3)
+  - FBSDKLoginKit (16.1.3):
+    - FBSDKCoreKit (= 16.1.3)
+
+DEPENDENCIES:
+  - "Capacitor (from `../node_modules/@capacitor/ios`)"
+  - "CapacitorCordova (from `../node_modules/@capacitor/ios`)"
+  - FBSDKCoreKit (= 16.1.3)
+  - FBSDKLoginKit (= 16.1.3)
+
+SPEC REPOS:
+  trunk:
+    - FBAEMKit
+    - FBSDKCoreKit
+    - FBSDKCoreKit_Basics
+    - FBSDKLoginKit
+
+EXTERNAL SOURCES:
+  Capacitor:
+    :path: "../node_modules/@capacitor/ios"
+  CapacitorCordova:
+    :path: "../node_modules/@capacitor/ios"
+
+SPEC CHECKSUMS:
+  Capacitor: b332cb737d447561e854039fb72195206685dce2
+  CapacitorCordova: 4ea17670ee562680988a7ce9db68dee5160fe564
+  FBAEMKit: af2972f39bb0f3f7c45998f435b007833c32ffb2
+  FBSDKCoreKit: 19e2e18b3be578d7a51fed8fdd8c152bef0b9511
+  FBSDKCoreKit_Basics: dd9826ce3c9fd9f8cdf8dbbd0ef0a53e6c0c9e7e
+  FBSDKLoginKit: c395c63a1a6cf4a8a1e6103fd94b8c46329ee81c
+
+PODFILE CHECKSUM: 84bd0ef43d21cc257916d7be16544e4f2fe7d24d
+
+COCOAPODS: 1.12.1
diff --git a/src/definitions.ts b/src/definitions.ts
@@ -28,7 +28,7 @@ export interface FacebookLoginPlugin {
   getProfile<T extends Record<string, unknown>>(options: {
     fields: readonly string[];
   }): Promise<T>;
-  logEvent(options: { name: string }): Promise<void>;
+  logEvent(options: { eventName: string }): Promise<void>;
   setAutoLogAppEventsEnabled(options: { enabled: boolean }): Promise<void>;
   setAdvertiserTrackingEnabled(options: { enabled: boolean }): Promise<void>;
   setAdvertiserIDCollectionEnabled(options: {

diff --git a/src/web.ts b/src/web.ts
@@ -41,7 +41,7 @@ declare interface Facebook {
     params: TParams,
     callback: (response: TResponse) => void,
   ): void;
-  logEvent(handle: (response: any) => void, options: { name: string }): void;
+  logEvent(handle: (response: any) => void, options: { eventName: string }): void;
   setAutoLogAppEventsEnabled(
     handle: (response: any) => void,
     options: { enabled: boolean },