fix(ios)!: linear rate adjustment #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robingenz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #134
Changes iOS rate mapping from
to a more predictable mapping
(x-axis = plugin speech rate, y-axis = native speech rate, assuming
AVSpeechUtteranceDefaultSpeechRateis 0.5)Note: Speech rate heavily depends on the selected tts-engine and voice. There will not be a perfect cross-platform speech rate match. From experimenting with android and iOS tts-engines and voices this adjustment seems to be a good compromise.
We should also consider removing the rate adjustment completely though. See a similar discussion on
react-native-ttshere. But that is another discussion.Pull request checklist
Please check if your PR fulfills the following requirements: