Refactor _assimilate_histogram and _regenerate_histogram
#1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods _regenerate_histogram and _assimilate_histogram hardly use self and can be moved into the histogram_utils module.
junholee6a
requested review from
ksneab7,
taylorfturner,
micdavis and
tyfarnan
as code owners
junholee6a
changed the title
_assimilate_histogram and _regenerate_histogram
|
I didn't add unit tests for these functions here because 1) the functions had no direct unit tests in the first place so code coverage won't change, and 2) |
|
Seems like there was a mypy error in the Python 3.8 tests. Will look into that |
thanks! |
auto-merge was automatically disabled
September 2, 2023 20:02
Head branch was pushed to by a user without write access
|
Had to rebuild some branches post |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #820
The functions
_assimilate_histogramand_regenerate_histogramare refactored as directed in the issue. Additionally,_assimilate_histogramno longer rounds bin edges, as this feature doesn't seem necessary and adds an additional argument to_assimilate_histogram.