Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrade 0.10.4 #1033

Closed
wants to merge 6 commits into from
Closed

Version upgrade 0.10.4 #1033

wants to merge 6 commits into from

Conversation

taylorfturner
Copy link
Contributor

No description provided.

ksneab7 and others added 6 commits August 9, 2023 20:31
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Taylor Turner <[email protected]>
* Make sure random_state is a list before indexed assignment

Currently, a mypy error occurs because we attempt to assign to
random_state[1] when random_state has type
Union[list[Any], tuple[Any]]. Tuples are immutable so this is a type
error.

We fix this by making random_state into a list before doing indexed
assignment on it.

* Add type guards for random_state

* Check random_state before random_state[1]

Co-authored-by: Michael Davis <[email protected]>

* Reorder conditions for consistency

Co-authored-by: Taylor Turner <[email protected]>

---------

Co-authored-by: Michael Davis <[email protected]>
Co-authored-by: Taylor Turner <[email protected]>
* added psi calculation to categorical columns

* Changed test value to non-calculated assignment
@taylorfturner taylorfturner added the Version Upgrade Release / version change PR label Sep 21, 2023
@taylorfturner taylorfturner self-assigned this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version Upgrade Release / version change PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants