Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/dotfile consolidation #382

Closed
wants to merge 21 commits into from
Closed

config/dotfile consolidation #382

wants to merge 21 commits into from

Conversation

ryanSoley
Copy link
Member

@ryanSoley ryanSoley commented Sep 18, 2023

What

  • consolidating dotfiles and config files into pyproject.toml
    • move .coveragerc into pyproject.toml
    • move setup.py into pyproject.toml
    • move most of setup.cfg into pyproject.toml
      • flake8 doesn't support toml configuration - I propose we switch to pylint in a followup
  • consolidating environment yamls into a single requirements.txt
    • optional dependencies now configured entirely in pyproject.toml
  • update workflows to reflect changes
  • update docs/readmes to reflect changes

How to Test

@ryanSoley ryanSoley added the enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs. label Sep 18, 2023
@ryanSoley ryanSoley requested a review from a team as a code owner September 18, 2023 14:02
@ryanSoley ryanSoley self-assigned this Sep 18, 2023
@@ -63,10 +66,12 @@ def test_publish_to_file(project_client):
project.log_experiment()
project.log_experiment()

catalog_yaml = publish(project.experiments(), output_filepath="memory://catalog.yml")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the memory filesystem started being weird when these tests were run via the edgetest plugin, so I switched it to a TemporaryDirectory. the memory filesystem can get weird when things are multi-processed - may be something to do with the way edgetest calls python/pytest

@ryanSoley ryanSoley marked this pull request as draft September 21, 2023 19:11
@ryanSoley
Copy link
Member Author

we're going to do this differently

@ryanSoley ryanSoley closed this Jun 14, 2024
@ryanSoley ryanSoley deleted the dotfile-consolidation branch June 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues & PRs that capture enhancements to existing features. Issues require associated PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant