Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple JSON wrapper #385

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Add a simple JSON wrapper #385

merged 4 commits into from
Sep 27, 2023

Conversation

stephenpardy
Copy link
Contributor

@stephenpardy stephenpardy commented Sep 22, 2023 •
edited
Loading

closes: #380

What

  • Adds a log_json helper function.
  • Adds a load_json helper function.

How to Test

  • Run unit tests
  • Run integration tests

@stephenpardy stephenpardy marked this pull request as ready for review September 26, 2023 19:32
@stephenpardy stephenpardy requested a review from a team as a code owner September 26, 2023 19:32
ryanSoley
ryanSoley approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ryanSoley ryanSoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great 🔥

@stephenpardy stephenpardy merged commit 5da6be6 into main Sep 27, 2023
6 checks passed
@stephenpardy stephenpardy deleted the json_helper branch September 27, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanSoley ryanSoley ryanSoley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a log_json method.
2 participants
@stephenpardy @ryanSoley