Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a TagContainer to handle key-value tags #429

Merged
merged 10 commits into from
Apr 12, 2024
Merged

adds a TagContainer to handle key-value tags #429

merged 10 commits into from
Apr 12, 2024

Conversation

ryanSoley
Copy link
Member

@ryanSoley ryanSoley commented Apr 11, 2024

closes #402


What

  • adds a TagContainer that extends from the native Python list
    • allows for indexing by string
      • when tags are indexed with a string, all tags with a <key>:<value> format will be considered and all <value>s corresponding to the string <key> will be returned
  • leverages this new functionality in _get_experiments_from_tags

How to Test

  • python -m pytest tests
  • run the updated tagging.ipynb notebook

@ryanSoley ryanSoley requested a review from a team as a code owner April 11, 2024 19:03
@ryanSoley ryanSoley self-assigned this Apr 11, 2024
Copy link

@apeterson7 apeterson7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ryanSoley ryanSoley merged commit 24cf86f into main Apr 12, 2024
7 checks passed
@ryanSoley ryanSoley deleted the tag-dict branch April 12, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use dictionary for Rubicon resource tagging
4 participants